Skip to content

perf: Make writing of ClojureCat ensembles more memory efficient #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

perf: Make writing of ClojureCat ensembles more memory efficient #176

wants to merge 1 commit into from

Conversation

Schaechtle
Copy link
Contributor

What does this do?

This uses (prn) to print a ClojureCat ensemble and re-directs the output in dvc.yaml to a file.

Why do we want this?

Solves previous memory issues when running the dvc pipeline, e.g. with large CES models.

Why is this a draft?

This is a draft because resulting ensemble for CES is too large to be loaded into iql.query:

 clj -M -m inferenceql.query.main --model m=data/xcat/xcat.merged.edn --lang permissive
Execution error (OutOfMemoryError) at jdk.internal.util.ArraysSupport/hugeLength (ArraysSupport.java:649).
Required array length 2147483639 + 9 is too large

Unless, there is an obvious fix to the above, I guess we still merge?

@zane comments welcome.

zane
zane approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@zane zane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combining the slurp with the EDN reading will further reduce memory usage.

@Schaechtle
Copy link
Contributor Author

Update: after chatting about this with Zane, we decided that we should use iql.query's slurp/model and fix the memory issues there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zane zane zane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Schaechtle @zane